Re: Common function for percent placeholder replacement - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Common function for percent placeholder replacement
Date
Msg-id 2707471.1671039603@sss.pgh.pa.us
Whole thread Raw
In response to Re: Common function for percent placeholder replacement  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
Justin Pryzby <pryzby@telsasoft.com> writes:
> On Wed, Dec 14, 2022 at 08:31:02AM +0100, Peter Eisentraut wrote:
>> +    return replace_percent_placeholders(base_command, "df", (const char *[]){target_detail, filename});

> This is a "compound literal", which I gather is required by C99.

> But I don't think that's currently being exercised, so I wonder if it's
> going to break some BF members.

It's pretty illegible, whatever it is.  Could we maybe expend a
few more keystrokes in favor of readability?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Minimal logical decoding on standbys
Next
From: Tom Lane
Date:
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION