Re: minor auth code cleanup - Mailing list pgsql-patches

From Tom Lane
Subject Re: minor auth code cleanup
Date
Msg-id 27027.1030461339@sss.pgh.pa.us
Whole thread Raw
In response to Re: minor auth code cleanup  (Neil Conway <neilc@samurai.com>)
Responses Re: minor auth code cleanup  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
>> There may be existing clients out there that miscompute the password
>> packet length.  Right now that does no harm.  With an Assert in place
>> in the backend, it will cause a database system restart.

> Good point. However, I still think a sanity check would be appropriate
> here. How about an elog(WARNING) ?

I think that elog(LOG) is probably the right thing.  IIRC, at that point
in startup we will not send anything short of ERROR to the client, so
elog(WARNING) is pointless from the client's point of view --- and a LOG
is actually more likely to get into the server's log than a WARNING.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: minor auth code cleanup
Next
From: Bruce Momjian
Date:
Subject: Re: minor auth code cleanup