Re: fd.c: flush data problems on osx - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fd.c: flush data problems on osx
Date
Msg-id 27003.1460582461@sss.pgh.pa.us
Whole thread Raw
In response to Re: fd.c: flush data problems on osx  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: fd.c: flush data problems on osx
List pgsql-hackers
I wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> A similar change seems to be needed in initdb.c's pre_sync_fname.

> Hmm, do we need to move this logic into src/common?

I concluded that sharing the code would be more trouble than it's worth,
because initdb.c's version of this is in fact not broken: it was never
taught about mmap, and it doesn't need to be IMO, because it's not that
performance-critical.

I fixed the other things I complained about and pushed this.  Please
check to see that the committed patch resolves your original problem.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Andres Freund
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <