Re: jdbc ResultSetMetaData::isWritable() - Mailing list pgsql-jdbc

From Rene Pijlman
Subject Re: jdbc ResultSetMetaData::isWritable()
Date
Msg-id 26efptc7irkgohu63n7echr7593pv0mdot@4ax.com
Whole thread Raw
In response to jdbc ResultSetMetaData::isWritable()  (Ian Wehrman <ian@labfire.com>)
Responses Re: jdbc ResultSetMetaData::isWritable()
List pgsql-jdbc
On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:
>public boolean isWritable(int column) throws SQLException
>{
>        if (isReadOnly(column))
>                return true;
>        else
>                return false;
>}

The author probably intended:

    public boolean isWritable(int column) throws SQLException
    {
        return !isReadOnly(column);
    }

And if he would have coded it this way he wouldn't have made
this mistake :-)

>hence, isWritable() will always return false. this is something
>of a problem :)

Why exactly? In a way, true is just as incorrect as false, and
perhaps it should throw "not implemented". But I guess that
would be too non-backwardly-compatible.

>let me know if i can provide further information.

Will you submit a patch?

Regards,
René Pijlman <rene@lab.applinet.nl>

pgsql-jdbc by date:

Previous
From: Liam Stewart
Date:
Subject: Re: driver source code indentation
Next
From: Bruce Momjian
Date:
Subject: Re: jdbc ResultSetMetaData::isWritable()