Re: Thread-safe nl_langinfo() and localeconv() - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Thread-safe nl_langinfo() and localeconv()
Date
Msg-id 26eb1e67-5171-44b8-ba11-83ece3c27ac4@eisentraut.org
Whole thread Raw
In response to Re: Thread-safe nl_langinfo() and localeconv()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 31.03.25 15:52, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> I'm not sure what to do with this.  If setlocale() and newlocale()
>> indeed behave differently in what set of locale names they accept, then
>> technically we ought to test both of them, since we do use both of them
>> later on.  Or maybe we push on with the effort to get rid of setlocale()
>> calls and then just worry about testing newlocale() (as this patch
>> does).  But right now, if newlocale() is more permissive, then we could
>> accept locale names that will later fail setlocale() calls, which might
>> be a problem.
> 
> I think the clear answer is "let's stop using setlocale(), and then
> not have to worry about any behavioral differences".

Right.  That effort is woven into various other ongoing work related to 
locales, collations, etc.  So for now, I'm going to close this 
commitfest entry as done, since $subject was achieved.  The rest can be 
picked up later, when the required progress in the other work has been made.




pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Some problems regarding the self-join elimination code
Next
From: Daniel Gustafsson
Date:
Subject: Re: Quote-less file names in error messages