Re: Reword docs of feature "Remove temporary files after backend crash" - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Reword docs of feature "Remove temporary files after backend crash"
Date
Msg-id 26d53a7c-bd66-2f42-7a90-2407228b2c6e@oss.nttdata.com
Whole thread Raw
In response to Re: Reword docs of feature "Remove temporary files after backend crash"  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Reword docs of feature "Remove temporary files after backend crash"  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers

On 2021/10/10 1:25, Bharath Rupireddy wrote:
> On Sat, Oct 9, 2021 at 9:42 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
>>
>> I doubt there's much confusion here - crashes are treated the same.  I think
>> the fix would be to say "server crash" rather than backend crash.
> 
> IIUC, the "server crash" includes any backend, auxiliary process,
> postmaster crash i.e. database cluster/instance crash. The commit
> cd91de0d1 especially added the temp file cleanup support if any
> backend or auxiliary process (except syslogger and stats collector)

Also the startup process should be in this exception list?


> crashes. The temp file cleanup in postmaster crash does exist prior to
> the commit cd91de0d1.
> 
> When we add the description about the new GUC introduced by the commit
> cd91de0d1, let's be clear as to which crash triggers the new temp file
> cleanup path.

If we really want to add this information, the description of
restart_after_crash seems more proper place to do that in.
remove_temp_files_after_crash works only when the processes are
reinitialized because restart_after_crash is enabled.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Next
From: Tom Lane
Date:
Subject: Re: ldap/t/001_auth.pl fails with openldap 2.5