Re: Not *quite* there on ecpg fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Not *quite* there on ecpg fixes
Date
Msg-id 26874.1191522160@sss.pgh.pa.us
Whole thread Raw
In response to Re: Not *quite* there on ecpg fixes  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> One thing I noticed is this:

> ifneq ($(PORTNAME), win32)
> OBJS += thread.o
> DLL_DEFFILE=libecpgdll.def
> endif

> Why are we defining DLL_DEFFILE for the non-win32 case but not for the 
> win32 case?

Comparing to the libpq Makefile, this seems definitely backward ---
presumably the result is that Makefile.shlib overwrites the deffile
with an all-symbols deffile, eliminating the intended limitation on
which symbols are exported.

Will fix.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Not *quite* there on ecpg fixes
Next
From: Alvaro Herrera
Date:
Subject: Re: First steps with 8.3 and autovacuum launcher