Re: HEAPDEBUGALL is broken - Mailing list pgsql-hackers

From Tom Lane
Subject Re: HEAPDEBUGALL is broken
Date
Msg-id 26609.1587303428@sss.pgh.pa.us
Whole thread Raw
In response to HEAPDEBUGALL is broken  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: HEAPDEBUGALL is broken  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Re: HEAPDEBUGALL is broken  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> The HEAPDEBUGALL define has been broken since PG12 due to tableam 
> changes.  Should we just remove this?  It doesn't look very useful. 
> It's been around since Postgres95.
> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL 
> (which still compiles correctly).  Would we want to keep that?

+1 for removing both.  There are a lot of such debug "features"
in the code, and few of them are worth anything IME.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Poll: are people okay with function/operator table redesign?
Next
From: James Coleman
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)