Re: HEAPDEBUGALL is broken - Mailing list pgsql-hackers

From Andres Freund
Subject Re: HEAPDEBUGALL is broken
Date
Msg-id 20200423034418.coxgdnfmnkiflkde@alap3.anarazel.de
Whole thread Raw
In response to Re: HEAPDEBUGALL is broken  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: HEAPDEBUGALL is broken
List pgsql-hackers
On 2020-04-19 09:37:08 -0400, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > The HEAPDEBUGALL define has been broken since PG12 due to tableam 
> > changes.  Should we just remove this?  It doesn't look very useful. 
> > It's been around since Postgres95.
> > If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL 
> > (which still compiles correctly).  Would we want to keep that?
> 
> +1 for removing both.  There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.

Belatedly: +many



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: xid wraparound danger due to INDEX_CLEANUP false
Next
From: Peter Geoghegan
Date:
Subject: Re: xid wraparound danger due to INDEX_CLEANUP false