On 08/04/2024 04:28, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Committed this. Thank you to everyone involved!
>
> Looks like perlcritic isn't too happy with the test code:
> koel and crake say
>
> ./src/test/libpq_encryption/t/001_negotiate_encryption.pl: Return value of flagged function ignored - chmod at line
138,column 2. See pages 208,278 of PBP. ([InputOutput::RequireCheckedSyscalls] Severity: 5)
> ./src/test/libpq_encryption/t/001_negotiate_encryption.pl: Return value of flagged function ignored - open at line
184,column 1. See pages 208,278 of PBP. ([InputOutput::RequireCheckedSyscalls] Severity: 5)
Fixed, thanks.
I'll make a note in my personal TODO list to add perlcritic to cirrus CI
if possible. I rely heavily on that nowadays to catch issues before the
buildfarm.
--
Heikki Linnakangas
Neon (https://neon.tech)
