Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment
Date
Msg-id 26430.1089657869@sss.pgh.pa.us
Whole thread Raw
In response to pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment  (momjian@svr1.postgresql.org (Bruce Momjian))
Responses Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path
List pgsql-committers
Tree view 
momjian@svr1.postgresql.org (Bruce Momjian) writes:
> Use strdup in pg_ctl for canonicalize_path on environment variable.
> Simplify postmaster call too.

You're not doing very well with this project :-(.  pg_ctl is now
actively broken, because the PGDATA value passed down to the
bootstrap backend is the one in the environment variable.  The
previous coding canonicalized that, this does not.

I do not like the "simplified" postmaster.c coding either; it may
save one line but it is harder to understand.

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment
Next
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server: Put back canonicalization of PGDATA environment variable.