Re: Fix oversight in pts_error_callback() - Mailing list pgsql-patches

From Tom Lane
Subject Re: Fix oversight in pts_error_callback()
Date
Msg-id 26391.1123687502@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix oversight in pts_error_callback()  ("Qingqing Zhou" <zhouqq@cs.toronto.edu>)
List pgsql-patches
"Qingqing Zhou" <zhouqq@cs.toronto.edu> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes
>> Please exhibit a case in which you feel this is needed.

> Suppose I want to print a debug info in parseTypeString() like this:
>     + elog(DEBUG1, "parse type %s", buf.data);
>      raw_parsetree_list = raw_parser(buf.data);

That's a contrived example (and if I believed it, I would think that the
right answer is to emit no errcontext if the elevel is less than ERROR).
Give me an actual use case in which the patch gives a better rather than
worse error report.  I think for most people it would just obfuscate the
message.

            regards, tom lane

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: 5 new entries for FAQ
Next
From: Tom Lane
Date:
Subject: Re: COPY FROM performance improvements