Re: static-if-inline - Mailing list pgsql-hackers

From Tom Lane
Subject Re: static-if-inline
Date
Msg-id 2638.1349712292@sss.pgh.pa.us
Whole thread Raw
In response to static-if-inline  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> What's being done in this patch is exactly what would be done in the
> ilist code.  So if there are problems with this, please speak up.

Stylistic gripe: in palloc.h you didn't follow the pattern of#ifndef USE_INLINEextern ...#endif
before (rather than after) the function definitions.  Nitpicky I know,
but if we're trying to create a pattern, we should be consistent.

The comment added in c.h has some grammar issues, too.  Looks good
otherwise.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Warnings from fwrite() in git head
Next
From: Tom Lane
Date:
Subject: Re: Warnings from fwrite() in git head