Re: BUG #15605: Unstable regression test "tablespace" - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #15605: Unstable regression test "tablespace"
Date
Msg-id 26305.1548255211@sss.pgh.pa.us
Whole thread Raw
In response to BUG #15605: Unstable regression test "tablespace"  (PG Bug reporting form <noreply@postgresql.org>)
Responses Re: BUG #15605: Unstable regression test "tablespace"  (Alexander Lakhin <exclusion@gmail.com>)
List pgsql-bugs
=?utf-8?q?PG_Bug_reporting_form?= <noreply@postgresql.org> writes:
> When running 'TESTS="$(printf "tablespace %.0s" `seq 1000`)" make
> check-tests' I get:
> ...
> It seems that the following query in src/test/regress/sql/tablespace.sql:
> SELECT relname, spcname FROM pg_catalog.pg_tablespace t, pg_catalog.pg_class c
>     where c.reltablespace = t.oid AND c.relname LIKE 'part%_idx';
> needs an "ORDER BY".

I'm totally unexcited by this.  Almost every script in our standard
regression suite is somewhat context-dependent, eg many of them depend
on tables or other objects created by previous scripts.  Trying to make
them be robust when run standalone would be a huge and ultimately pretty
pointless exercise.

In the case of the tablespace script, it evidently has some dependency on
being run in a fresh database, but so what?  It always will be, when used
as directed.  (I do not recall the reason why we run it first, but
I remember that there was some good reason, possibly to do with crash
recovery.)

            regards, tom lane


pgsql-bugs by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: BUG #15606: Postgres incorrectly returns syntax error when usingWITH clacuse
Next
From: Alexander Lakhin
Date:
Subject: Re: BUG #15605: Unstable regression test "tablespace"