Re: [COMMITTERS] pgsql: Sigh ... - Mailing list pgsql-patches

Andrew Dunstan <andrew@dunslane.net> writes:
> !         print O "#define RELSEG_SIZE ",
> !             (1024 / $self->{options}->{blocksize}) *
> !                 $self->{options}->{segsize} * 1024, "\n";

This doesn't look quite right; unless the arithmetic is being done in
floating point?  I had it like this in configure.in:

RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`

Also it looks like you missed adding segsize to the config.pl comments.

            regards, tom lane