Re: [HACKERS] COPY FROM STDIN behaviour on end-of-file - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] COPY FROM STDIN behaviour on end-of-file
Date
Msg-id 26219.1494956711@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] COPY FROM STDIN behaviour on end-of-file  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] COPY FROM STDIN behaviour on end-of-file  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, May 16, 2017 at 1:29 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I had been supposing that this was a feature addition and should be left
>>> for the next commitfest.  But given that it already works as-expected on
>>> popular platform(s), the fact that it doesn't work the same on some other
>>> platforms seems like a portability bug rather than a missing feature.
>>> Now I'm inclined to treat it as a bug and back-patch.

>> BTW, the main argument for considering it a new feature is that we don't
>> suggest anywhere in our code or docs that this will work.  If we're going
>> to go out of our way to make it work, should we mention it in psql-ref?
>> And what about changing the interactive prompt, along the lines of
>> End with a backslash and a period on a line by itself, or an EOF signal.

> Well, the current behavior is so wonky and inconsistent that it's hard
> for me to view it as anything but a bug.  I mean, one can argue about
> exactly what an EOF should do in any given situation, but surely it
> can't be right for it to do one thing on one platform and something
> else on a different platform.

Oh, I still believe it's a bug.  I'm just saying that if we're going
to fix it, we should do more than just make a minimal code change.

BTW, it would be a good idea for somebody to check this out on Windows,
assuming there's a way to generate a keyboard EOF signal there.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] COPY FROM STDIN behaviour on end-of-file
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] COPY FROM STDIN behaviour on end-of-file