Postgres Pro
Downloads
Home   >   mailing lists

Re: moving some code out of explain.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: moving some code out of explain.c
Date
Msg-id 2619147.1740690725@sss.pgh.pa.us
Whole thread Raw
In response to Re: moving some code out of explain.c  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: moving some code out of explain.c
List pgsql-hackers
Tree view 
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Feb 27, 2025 at 3:05 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Did you look at avoiding that with our standard trick of writing
>> detail-free struct declarations?

> OK, here's a patch that does that. Thoughts?

+1, but how about explain_dr.h too?  It doesn't seem though that
we can avoid #include "executor/instrument.h" there, so it'd be
a little asymmetrical.  But the executor inclusion doesn't seem
nearly as much almost-circular.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PROPOSAL] : Disallow use of empty column name in (column_name '') in ALTER or CREATE of foreign table.
Next
From: Robert Haas
Date:
Subject: Re: [PROPOSAL] : Disallow use of empty column name in (column_name '') in ALTER or CREATE of foreign table.