Re: pgsql: Transfer statistics during pg_upgrade. - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Transfer statistics during pg_upgrade.
Date
Msg-id 25d26774-25fa-46f2-9888-c6a707d1fef7@dunslane.net
Whole thread Raw
In response to pgsql: Transfer statistics during pg_upgrade.  (Jeff Davis <jdavis@postgresql.org>)
List pgsql-committers
On 2025-02-20 Th 4:29 AM, Jeff Davis wrote:
> Transfer statistics during pg_upgrade.


Small nit.

I notice this commit has introduced a couple of dubious uses of 
"mututally exclusive":

doc/src/sgml/ref/pg_dump.sgml:        This option is mutually exclusive 
to <option>--data-only</option>
doc/src/sgml/ref/pg_dump.sgml-        and 
<option>--statistics-only</option>.
--
doc/src/sgml/ref/pg_restore.sgml:        This option is mutually 
exclusive of <option>--data-only</option>
doc/src/sgml/ref/pg_restore.sgml-        and 
<option>--statistics-only</option>.


I don't think this is idiomatic usage, and it's possibly not correct 
usage. At best it is jarring. One does not normally follow "mutually 
exclusive" with a preposition. I would replace the these with something 
like "This option cannot be used with ...". If you want to use the 
phrase, it should be something like "This option and ... are mutually 
exclusive."


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT)
Next
From: Andres Freund
Date:
Subject: pgsql: Make test portlock logic work with meson