Re: [HACKERS] snprintf causes regression tests to fail - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] snprintf causes regression tests to fail
Date
Msg-id 25924.1109624284@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] snprintf causes regression tests to fail  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] snprintf causes regression tests to fail
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Ah, the problem was introduced here:

Right, it was my fault.

> The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
> below the printf 64-bit tests.  This commited patch moves
> PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and
> just before printf 64-bit args are tested.

This patch breaks things in a different way: you should not have moved
the AC_LIBOBJ(snprintf) step.  Also you randomly placed the arg-control
test between a chunk of code and the comment describing same.

Corrected version committed.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] snprintf causes regression tests to fail
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] snprintf causes regression tests to fail