Re: PGDLLEXPORTing all GUCs? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PGDLLEXPORTing all GUCs?
Date
Msg-id 25882.1399469706@sss.pgh.pa.us
Whole thread Raw
In response to PGDLLEXPORTing all GUCs?  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: PGDLLEXPORTing all GUCs?
List pgsql-hackers
Craig Ringer <craig@2ndquadrant.com> writes:
> Is there any reason _not_ to PGDLLEXPORT all GUCs, other than cosmetic
> concerns?

That seems morally equivalent to "is there a reason not to make every
static variable global?".

IOW, no, I don't accept this proposition.  Every time we DLLEXPORT some
variable, we lose the freedom to redefine it later.  So DLLEXPORT'ing GUCs
should be on a case by case basis, just as for any other variable.  In
some cases it might be smarter to export a wrapper function.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Wanted: jsonb on-disk representation documentation
Next
From: Tom Lane
Date:
Subject: Re: Wanted: jsonb on-disk representation documentation