Re: [HACKERS] pgsql: Add sql_drop event for event triggers - Mailing list pgsql-committers

From Tom Lane
Subject Re: [HACKERS] pgsql: Add sql_drop event for event triggers
Date
Msg-id 2565.1365523150@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pgsql: Add sql_drop event for event triggers  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
Responses Re: [HACKERS] pgsql: Add sql_drop event for event triggers
List pgsql-committers
Dimitri Fontaine <dimitri@2ndquadrant.fr> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I think it would be difficult and probably dangerous to have PG_TRY
>> for only some utility commands, so not much to be done about that.
>> The main thing is to not invoke event trigger code for BEGIN/ABORT/SET.

> What about splitting the big switch statement into two of them? The
> first one for transaction control statements, and then the other bigger
> one.

Sounds like considerable uglification to fix a performance issue that's
entirely hypothetical... let's see some numbers that prove it's worth
worrying about before we do that.

            regards, tom lane


pgsql-committers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: [HACKERS] pgsql: Add sql_drop event for event triggers
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] pgsql: Add sql_drop event for event triggers