Re: Minor lmgr code cleanup - Mailing list pgsql-patches

From Tom Lane
Subject Re: Minor lmgr code cleanup
Date
Msg-id 25610.1062944347@sss.pgh.pa.us
Whole thread Raw
In response to Minor lmgr code cleanup  (Manfred Koizar <mkoi-pg@aon.at>)
Responses Re: Minor lmgr code cleanup
List pgsql-patches
Manfred Koizar <mkoi-pg@aon.at> writes:
> [large patch]

Looks reasonable except

> +#define BITS_OFF(i) ~(1 << (i))

I'd put another pair of parens around that.  Also, it might be worth
moving into a header file.  There is at least one place in proc.c that
manipulates lock masks using explicit shifts, because BITS_ON/BITS_OFF
weren't visible outside lock.c.  It'd be good to fix it.

BTW, did you check that the code still compiles with LOCK_DEBUG enabled?
How about contrib/userlock?

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: MinGW patch
Next
From: Bruce Momjian
Date:
Subject: Re: MinGW patch