Re: Don't overwrite scan key in systable_beginscan() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Don't overwrite scan key in systable_beginscan()
Date
Msg-id 2560232.1723179346@sss.pgh.pa.us
Whole thread Raw
In response to Re: Don't overwrite scan key in systable_beginscan()  (Noah Misch <noah@leadboat.com>)
Responses Re: Don't overwrite scan key in systable_beginscan()
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> On Thu, Aug 08, 2024 at 08:46:35AM +0200, Peter Eisentraut wrote:
>> I propose to fix that by making a copy of the scan keys passed by the caller
>> and make the modifications there.

> No objection, but this would obsolete at least some of these comments (the
> catcache.c ones if nothing else):

That ties into something I forgot to ask: aren't there any copy steps
or other overhead that we could remove, given this new API constraint?
That would help address Robert's concern.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Don't overwrite scan key in systable_beginscan()
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Found issues related with logical replication and 2PC