Re: [PATCH] Expand character set for ltree labels - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Expand character set for ltree labels
Date
Msg-id 2549024.1664999784@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Expand character set for ltree labels  (Garen Torikian <gjtorikian@gmail.com>)
Responses Re: [PATCH] Expand character set for ltree labels  (Garen Torikian <gjtorikian@gmail.com>)
List pgsql-hackers
Garen Torikian <gjtorikian@gmail.com> writes:
>> Perhaps the docs are a bit unclear about that, but it's not
>> restricted to ASCII alphanumerics.  AFAICS the code will accept
>> whatever iswalpha() and iswdigit() will accept in the database's
>> default locale.

> Sorry but I don't think that is correct. Here is the single
> definition check of what constitutes a valid character:
> https://github.com/postgres/postgres/blob/c3315a7da57be720222b119385ed0f7ad7c15268/contrib/ltree/ltree.h#L129

> As you can see, there are no `is_*` calls at all.

Did you chase down what t_isalpha and t_isdigit do?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: ts_locale.c: why no t_isalnum() test?
Next
From: Andres Freund
Date:
Subject: meson PGXS compatibility