Re: Broken SSL tests in master - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Broken SSL tests in master
Date
Msg-id 25490.1480642009@sss.pgh.pa.us
Whole thread Raw
In response to Re: Broken SSL tests in master  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Broken SSL tests in master
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Fri, Dec 2, 2016 at 8:36 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> Correct, but I'm defining that as user error.  If hostaddr is
>> specified, host is not used to decide what to connect to, so it makes
>> no sense for it to be a string of multiple host names.  If we allowed
>> multiple hostaddrs, as has been proposed, then we'd need to be more
>> clever about this.

> Would it be better to return NULL instead then.

That would likely just result in application core dumps.
See notes for commit 490cb21f7.  I think we've established an expectation
that only a NULL argument will elicit a NULL return from PQhost.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Broken SSL tests in master
Next
From: Michael Paquier
Date:
Subject: Re: Proposal for changes to recovery.conf API