Re: Fix initdb for path with whitespace and at char - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix initdb for path with whitespace and at char
Date
Msg-id 25451.1398881905@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix initdb for path with whitespace and at char  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> I committed the non-invasive fixes to backbranches (and master too, just 
> to keep it in sync), but the attached is what I came up with for master.

The malloc's in the new system.c file should be pg_malloc, or else have
custom defenses against out-of-memory (possibly returning ENOMEM to
the caller would be best?).  Also, it seems like a good idea to save and
restore errno across the ending free() calls.  I don't know if Windows'
version of free() can change errno, but we've definitely found that to
be possible on other platforms.

Looks good otherwise.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: GSoC on WAL-logging hash indexes
Next
From: Peter Geoghegan
Date:
Subject: Re: GSoC on WAL-logging hash indexes