Re: Allow placeholders in ALTER ROLE w/o superuser - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Allow placeholders in ALTER ROLE w/o superuser
Date
Msg-id 254314.1672201780@sss.pgh.pa.us
Whole thread Raw
In response to Re: Allow placeholders in ALTER ROLE w/o superuser  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Allow placeholders in ALTER ROLE w/o superuser  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
Justin Pryzby <pryzby@telsasoft.com> writes:
> This fails when run more than once:
> time meson test --setup running --print test_pg_db_role_setting-running/regress

Ah.

> It didn't fail for you because it says:
> ./src/test/modules/test_pg_db_role_setting/Makefile
> +# disable installcheck for now
> +NO_INSTALLCHECK = 1

So ... exactly why is the meson infrastructure failing to honor that?
This test looks sufficiently careless about its side-effects that
I completely agree with the decision to not run it in pre-existing
installations.  Failing to drop a created superuser is just one of
its risk factors --- it also leaves around pg_db_role_setting entries.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrey Lepikhov
Date:
Subject: Re: POC, WIP: OR-clause support for indexes
Next
From: Amit Kapila
Date:
Subject: Re: Data loss on logical replication, 12.12 to 14.5, ALTER SUBSCRIPTION