Re: vacuum hint on elog - Mailing list pgsql-patches

From Tom Lane
Subject Re: vacuum hint on elog
Date
Msg-id 25395.1106428859@sss.pgh.pa.us
Whole thread Raw
In response to vacuum hint on elog  (Neil Conway <neilc@samurai.com>)
Responses Re: vacuum hint on elog  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> It occurred to me that if we elog(ERROR) during VACUUM, the vacuum
> activity hint will not be reset.

The code beginning at freelist.c line 645 is intended to deal with this.

> Attached is a patch which resets the vacuum activity hint in
> AbortTransaction().

I dislike exposing such low-level issues to AbortTransaction().
If an explicit reset is needed, there should be something like
an AtAbort_Buffers() call that does this as well as any other
low-level issues needed (eg AbortBufferIO()).  Note that you
missed AbortSubTransaction() anyway.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Dave Page"
Date:
Subject: Re: pg_autovacuum/Win32 Fixes
Next
From: Bruce Momjian
Date:
Subject: Re: [DOCS] bug in 8.0 manual, section 37.6, PL/Perl Triggers