Re: inline newNode() - Mailing list pgsql-patches

From Tom Lane
Subject Re: inline newNode()
Date
Msg-id 2532.1034092432@sss.pgh.pa.us
Whole thread Raw
In response to Re: inline newNode()  (Neil Conway <neilc@samurai.com>)
Responses Re: inline newNode()  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> I don't like making the code GCC-specific any more than anyone else
> does, but given that the code-bloat is specific to the inline version
> of newNode (which in the scheme I described earlier would be
> GCC-only) -- so introducing a GCC-specific fix for a GCC-specific
> problem isn't too bad, IMHO.

> Or we could just use your other suggestion: define a variant of
> MemSet() and use it when we know it's safe. Not sure which is the
> better solution: any comments?

If we're going with a GCC-only approach to inlining newNode then it
seems like a tossup to me too.  Any other thoughts out there?

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: inline newNode()
Next
From: Bruce Momjian
Date:
Subject: Re: inline newNode()