Downloads
Home   >   mailing lists

Re: Extend COPY FROM with HEADER to skip multiple lines - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Extend COPY FROM with HEADER to skip multiple lines
Date
Msg-id 252cd702-6fbb-4c15-b950-bcc2ef663915@oss.nttdata.com
Whole thread Raw
In response to Re: Extend COPY FROM with HEADER to skip multiple lines  (Shinya Kato <shinya11.kato@gmail.com>)
Responses Re: Extend COPY FROM with HEADER to skip multiple lines
List pgsql-hackers
Tree view 

On 2025/06/27 11:55, Shinya Kato wrote:
> I thought about the approach, and had a minor concern about the following inconsistency between the option and its
internalimplementation:
 
> - When the option is set to "MATCH", header_line becomes -1.
> - When the option is set to -1, it's an error.

I think this inconsistency is acceptable, since users won't encounter it directly.
Also the value -1 isn't used explicitly, i.e., it's always referenced through a macro
for "match", which keeps the code readable and understandable.


> However, your patch is clear, and it seems we don't need to worry about this concern.
> Your patch looks good to me.

Thanks for reviewing the patch! I've marked it as ready for committer.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

pgsql-hackers by date:

Previous
From: Shinya Kato
Date:
Subject: Re: Extend COPY FROM with HEADER to skip multiple lines
Next
From: jian he
Date:
Subject: pg_restore --no-policies should not restore policies' comment