Re: arrays as pl/perl input arguments [PATCH] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: arrays as pl/perl input arguments [PATCH]
Date
Msg-id 2528.1294867323@sss.pgh.pa.us
Whole thread Raw
In response to Re: arrays as pl/perl input arguments [PATCH]  (Alexey Klyukin <alexk@commandprompt.com>)
Responses Re: arrays as pl/perl input arguments [PATCH]  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Alexey Klyukin <alexk@commandprompt.com> writes:
> Since almost everyone votes for making the new behavior a default option I'm
> inclined to do that change, although I'm against throwing out the
> compatibility option. There are many other reasons except for PL/Perl for
> people to upgrade to 9.1, let's not force them to rewrite their Perl code
> if they were not planning to do that.

IMO a GUC for this completely sucks, because if you do need to convert
your Perl functions, the only way to do it is to have a flag day wherein
they all change at once.  And what about people writing Perl functions
that they'd like to give to other people?

If you have to have a flag, the only useful sort of flag is one that can
be attached to individual functions.  Compare what we did for
plpgsql.variable_conflict in 9.0.  I don't know how practical that will
be in plperl, though.

I thought the idea of overloading the string representation to look like
the old style was a cute solution.  If we don't have anyone at hand who
knows how to do that, let's find someone who does.  Not break our users'
code because we're too lazy to find out how to do it properly.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: libpq documentation cleanups (repost 3)
Next
From: Andrew Dunstan
Date:
Subject: Re: arrays as pl/perl input arguments [PATCH]