Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
>> Seems reasonable, but I have a stylistic gripe ...
>> I suspect you named it this way because you intend to pass it as a
>> parameter to all these routines later,
> Actually, the function itself is going to obtain it via a
> TransactionGetDeferredTriggers() call so it's going to be a variable
> local to the function. I'm not sure if it can be made a parameter,
My thought would be that TransactionGetDeferredTriggers() ought to be
called in one place that then passes the list pointer to the other
subroutines. I haven't looked at the code in detail to see how this
fits in ... but I don't like the notion of all these little functions
independently fetching a pointer from some nontrivial function. That
opens you up to interesting problems if different functions manage to
fetch different results.
regards, tom lane
