Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV
Date
Msg-id 25054.1060004981@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV  (Joe Conway <mail@joeconway.com>)
Responses Re: [HACKERS] statement level trigger causes pltcl, plpython
List pgsql-patches
Joe Conway <mail@joeconway.com> writes:
> Note that I also changed behavior in that when trigdata->tg_event
> doesn't match anything known -- instead of pressing on with a value of
> "UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made
> no sense to me, but you may not want to change existing behavior in this
> way (even though it seems to me that it is a "should not happen" kind of
> error).

Seems reasonable to me.  As a matter of style, the "unrecognized" elogs
should print the offending tg_event value; otherwise the patch looks fine.

> If this patch is acceptable, I'll make similar changes to plpython.

Please do.

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Updated french po files
Next
From: Joe Conway
Date:
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython