Re: [HACKERS] \h tab-completion - Mailing list pgsql-hackers

From David Steele
Subject Re: [HACKERS] \h tab-completion
Date
Msg-id 249ad85c-3955-d19b-305f-1b4c5ad1226c@pgmasters.net
Whole thread Raw
In response to Re: [HACKERS] \h tab-completion  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] \h tab-completion  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
Hi Andreas,

On 3/1/17 8:47 AM, Peter Eisentraut wrote:
> On 2/3/17 07:12, Andreas Karlsson wrote:
>> On 01/25/2017 07:13 AM, Michael Paquier wrote:
>>> What I think you should do is making the code path of
>>> \\h smarter with some exceptions by using TailMatchesCS2() for ALTER.
>>> There is as well the case of DROP commands that should be treated by
>>> the way.
>>
>> Yes, I think that is correct approach. I have attached a patch where I 
>> add completion for \h ALTER and \h DROP.
> 
> Instead of creating another copy of list_ALTER, let's use the
> words_after_create list and write a version of
> create_command_generator/drop_command_generator.

Do you know when you will have a new patch available for review that
incorporates Peter's request?

Thanks,
-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: [HACKERS] IF (NOT) EXISTS in psql-completion
Next
From: Kevin Grittner
Date:
Subject: [HACKERS] Re: [GSOC 17] Eliminate O(N^2) scaling from rw-conflict trackingin serializable transactions