Re: psql display of Unicode combining characters in 8.2 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: psql display of Unicode combining characters in 8.2
Date
Msg-id 24653.1165800845@sss.pgh.pa.us
Whole thread Raw
In response to Re: psql display of Unicode combining characters in 8.2  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: psql display of Unicode combining characters in 8.2
List pgsql-hackers
I wrote:
> What about the other way around: use the \u output convention only for
> things we can specifically identify as control chars, and assume that
> anything else with zero width is a combining char?  Is there anything
> other than 0-31 and 128-159 that should really get the \u treatment?

Actually, looking at the comments for ucs_wcwidth() in wchar.c, it seems
that this is already accounted for in the "dsplen" output: characters
for which -1 is returned are control characters, characters for which
0 is returned should be printed as-is and counted as zero width.  So the
bug is just that pg_wcsformat conflates the two cases.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 8.2 Partition lock changes and resource queuing.
Next
From: Mark Kirkwood
Date:
Subject: Re: 8.2 Partition lock changes and resource queuing.