Re: COMMENT ON - Mailing list pgsql-hackers

From Tom Lane
Subject Re: COMMENT ON
Date
Msg-id 2457.1000223431@sss.pgh.pa.us
Whole thread Raw
In response to Re: COMMENT ON  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: COMMENT ON
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
>> COMMENT ON AGGREGATE my_aggregate double precision IS 'Computes
>> sample variance';
>> 
>> works but looks strange syntax. Should we fix the program or docs?

> I vote for fixing the program.

If we fix this, we should also change DROP AGGREGATE, which also uses
the paren-less syntax.  (I think the COMMENT ON syntax was modeled on
DROP.)

I'd be in favor of changing, but we do need to maintain consistency.

Another issue is that pg_dump knows about using both of these
commands... we'll have a compatibility problem if we don't continue
to accept the old syntax for awhile.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "P. Dwayne Miller"
Date:
Subject: COPY command WITH NULLs bug?
Next
From: Thomas Lockhart
Date:
Subject: Re: factorial doc bug?