Re: [PATCH] Caching for stable expressions with constant arguments v3 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Caching for stable expressions with constant arguments v3
Date
Msg-id 2433.1323113774@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Caching for stable expressions with constant arguments v3  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: [PATCH] Caching for stable expressions with constant arguments v3
List pgsql-hackers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> On 05.12.2011 20:53, Marti Raudsepp wrote:
>> I considered stripping CacheExpr nodes later in PL/pgSQL, but I can't
>> remember right now why I rejected that approach (sorry, it's been 2
>> months).

> Yet another idea would be to leave the CacheExprs there, but provide a 
> way to reset the caches. PL/pgSQL could then reset the caches between 
> every invocation.

We're likely to need a way to reset these caches anyway, at some point...

> Or pass a flag to ExecInitExpr() to skip through the CacheExprs.

Not sure what you mean by that --- are you imagining that the ExprState
tree would have structure not matching the Expr tree?  That seems just
about guaranteed to break something somewhere.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: planner fails on HEAD
Next
From: Heikki Linnakangas
Date:
Subject: Re: [PATCH] Caching for stable expressions with constant arguments v3