Re: BUG #1545: LIBPQ Windows Version not calling WSACleanup for - Mailing list pgsql-bugs

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Jason Erickson wrote:
>> The only place WSACleanup is being called is libpqdll when the process
>> detaches the DLL (if the libpq is not staticly linked in), which matches up
>> with the WSAStartup when the process attaches to the DLL.
>>
>> The WSAStartup in the fe-connect.c->makeEmptyPGconn() does not have a
>> matching WSACleanup.  WSACleanup could possibly be placed in freePGconn(),
>> but unsure if all possible error cases will go through this function.
>>
>> This problem exists in both 8.0.1 and 7.4.7 of the libpq interface for
>> Windows.

> I agree freePGconn() is the proper place.  I will apply the following
> patch to current CVS and to 8.0.X.  8.0.3 is being packaged now so I
> will wait for 8.0.4.

Actually ... why do we need a WSAStartup in makeEmptyPGconn?  If we have
one in DLL attach, isn't that sufficient?

            regards, tom lane