Re: Support json_errdetail in FRONTEND builds - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Support json_errdetail in FRONTEND builds
Date
Msg-id 2406032.1710464693@sss.pgh.pa.us
Whole thread Raw
In response to Re: Support json_errdetail in FRONTEND builds  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Support json_errdetail in FRONTEND builds
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> Hmm.  I am not sure how much protection this would offer, TBH.  One
> thing that I find annoying with common/stringinfo.c as it is currently
> is that we have two exit() calls in the enlarge path, and it does not
> seem wise to me to spread that even more.

> My last argument sounds like a nit for HEAD knowing that this does not
> impact libpq that has its own pqexpbuffer.c to avoid issues with
> palloc, elog and exit, but that could be a problem if OAuth relies
> more on these code paths in libpq.

I hope nobody is expecting that such code will get accepted.  We have
a policy (and an enforcement mechanism) that libpq.so must not call
exit().  OAuth code in libpq will need to cope with using pqexpbuffer.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Combine Prune and Freeze records emitted by vacuum
Next
From: James Coleman
Date:
Subject: Re: [DOCS] HOT - correct claim about indexes not referencing old line pointers