Re: pgsql-server: Use canonicalize_path for -D, GUC paths, and paths coming - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server: Use canonicalize_path for -D, GUC paths, and paths coming
Date
Msg-id 2389.1089590567@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql-server: Use canonicalize_path for -D, GUC paths,  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: pgsql-server: Use canonicalize_path for -D, GUC paths,
List pgsql-committers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
>> None of these are correct.  canonicalize_path is only intended for
>> directory names not file names.  (I think the same problem applies
>> to several of your GUC variable changes, too.)

> canonicalize_path changes \ to /, and trims the trailing slash.

... and probably breaks the GUC variables that represent search paths,
rather than single file/directory names.  Certainly canonicalizing those
values in toto will not have the desired effects; you'd need to
canonicalize the path elements after they are extracted.

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server: Remove: < * Allow moving sequences and toast tables to
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql-server: Use canonicalize_path for -D, GUC paths,