Re: improve pg_restore warning on text dump input - Mailing list pgsql-hackers

From Tom Lane
Subject Re: improve pg_restore warning on text dump input
Date
Msg-id 23743.1325616929@sss.pgh.pa.us
Whole thread Raw
In response to improve pg_restore warning on text dump input  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: improve pg_restore warning on text dump input  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
>  From time to time there are complaints because people mistakenly feed a 
> text format dump to pg_restore and get back a somewhat cryptic message 
> about the file not being a valid archive. It's been suggested that we 
> should have pg_restore run the file through psql, but that would involve 
> more work than I at least care to give the problem. However, I think we 
> should give a nicer message, suggesting the user try feeding the file to 
> psql instead. The attached small patch does that.

It would probably be better if you put this test before the one that
insists the file is at least 512 bytes.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: improve pg_restore warning on text dump input
Next
From: Robert Haas
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe