Re: GCC memory barriers are missing "cc" clobbers - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GCC memory barriers are missing "cc" clobbers
Date
Msg-id 23561.1411135081@sss.pgh.pa.us
Whole thread Raw
In response to Re: GCC memory barriers are missing "cc" clobbers  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: GCC memory barriers are missing "cc" clobbers  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-09-19 12:00:16 +0200, Andres Freund wrote:
>> But addl sets condition flags. So this really also needs a "cc" clobber?
>> Or am I missing something?

> What I missed is that x86 has an implied "cc" clobber for every inline
> assembly statement. So forget that.

While it might not be buggy as it stands, I think we should add the "cc"
rather than rely on it being implicit.  One reason is that people will
look at the x86 cases when developing code for other architectures, and
they could easily forget to add "cc" on machines where it does matter.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: jsonb format is pessimal for toast compression
Next
From: Rahila Syed
Date:
Subject: Re: [REVIEW] Re: Compression of full-page-writes