Re: Adding NetBSD and OpenBSD to Postgres CI - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Adding NetBSD and OpenBSD to Postgres CI
Date
Msg-id 2354849.1734458989@sss.pgh.pa.us
Whole thread Raw
In response to Re: Adding NetBSD and OpenBSD to Postgres CI  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Adding NetBSD and OpenBSD to Postgres CI
List pgsql-hackers
I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Was about to apply that, but then started to wonder if we don't need the same
>> for configure? And it sure looks like that has the same problem?
>> Which also confuses me some, at some point this presumably worked?

> The configure path does work on NetBSD 10, and has for some time.

Ah, sorry, I'd forgotten that bsd_auth.h only exists on OpenBSD.
We correctly detect that the header is not there on NetBSD.

I tried it on OpenBSD 7.0, which is the only OpenBSD image I have
laying about at the moment, and configure correctly finds that the
"AC_CHECK_HEADER(bsd_auth.h, [], ...)" test succeeds.  So it looks
to me like we should not need the sys/types.h include --- unless
they broke it in some more-recent release?

(It looks like none of our OpenBSD BF animals are testing
--with-bsd-auth, which is surely bad.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Exceptional md.c paths for recovery and zero_damaged_pages
Next
From: Jeff Davis
Date:
Subject: Re: Remaining dependency on setlocale()