Re: Logical replication existing data copy - Mailing list pgsql-hackers

On 25/03/17 07:52, Peter Eisentraut wrote:
> On 3/24/17 10:09, Petr Jelinek wrote:
>> On 24/03/17 15:05, Peter Eisentraut wrote:
>>> On 3/23/17 19:32, Petr Jelinek wrote:
>>>> Yes, I also forgot to check if the table actually exists on subscriber
>>>> when fetching them in CREATE SUBSCRIPTION (we have check during
>>>> replication but not there).
>>> I think for this we can probably just change the missing_ok argument of
>>> RangeVarGetRelid() to false.
>>>
>>> Unless we want the custom error message, in which case we need to change
>>> AlterSubscription_refresh(), because right now it errors out because
>>> missing_ok = false.
>>>
>> You are right, stupid me.
> Committed this version.
>

Minor niggle:

bench=# DROP PUBLICATION pgbench;
DROP STATISTICS                                   <===

I'm guessing that notification is wrong.

regards

Mark