Re: GinPageIs* don't actually return a boolean - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GinPageIs* don't actually return a boolean
Date
Msg-id 23523.1455215837@sss.pgh.pa.us
Whole thread Raw
In response to Re: GinPageIs* don't actually return a boolean  (Andres Freund <andres@anarazel.de>)
Responses Re: GinPageIs* don't actually return a boolean
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> And anyway, these macros are a potential issue even without stdbool.h
> style booleans.

Absolutely; they don't work safely for testing bits that aren't in the
rightmost byte of a flag word, for instance.  I'm on board with making
these fixes, I'm just unconvinced that stdbool is a good reason for it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Performance degradation in commit ac1d794
Next
From: Andres Freund
Date:
Subject: Re: GinPageIs* don't actually return a boolean