Re: [HACKERS] Preliminary results for proposed new pgindent implementation - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Preliminary results for proposed new pgindent implementation
Date
Msg-id 23382.1497665887@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Preliminary results for proposed new pgindentimplementation  (Piotr Stefaniak <postgres@piotr-stefaniak.me>)
Responses Re: [HACKERS] Preliminary results for proposed new pgindent implementation
List pgsql-hackers
Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
> On 2017-06-17 00:02, Tom Lane wrote:
>> What I'm testing with right now has just four differences from your repo:

> There are also the "portability fixes" and they're the main problem.

Fair enough.

> I've simply removed things like capsicum or __FBSDID() because I thought
> it wouldn't be a problem since Postgres will have its own copy of indent
> anyway (so that its behavior is not a moving target). I can ifdef-out
> them instead of removing entirely, I just didn't think it was important
> anymore.

We should be able to deal with those via some #define hackery, no?

> I expect to be in trouble for replacing err() and errx(), though.

Understood.  I think we could deal with this by providing err() and
errx() in a support file that would be part of our distribution but
not yours.
        regards, tom lane



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: [HACKERS] how are the rpms configured that are available inPostgreSQL RPM Building Project - Yum Repository
Next
From: Ashutosh Sharma
Date:
Subject: Re: [HACKERS] Getting server crash on Windows when using ICU collation