Re: bugfix: --echo-hidden is not supported by \sf statements - Mailing list pgsql-hackers

From Tom Lane
Subject Re: bugfix: --echo-hidden is not supported by \sf statements
Date
Msg-id 23327.1358182577@sss.pgh.pa.us
Whole thread Raw
In response to bugfix: --echo-hidden is not supported by \sf statements  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: bugfix: --echo-hidden is not supported by \sf statements
Re: bugfix: --echo-hidden is not supported by \sf statements
List pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes:
> this is very simple patch -  it enables hidden_queries  for commands
> \sf and \ef to be consistent with other describing commands.

So far as I can tell, get_create_function_cmd (and lookup_function_oid
too) were intentionally designed to not show their queries, and for that
matter they go out of their way to produce terse error output if they
fail.  I'm not sure why we should revisit that choice.  In any case
it seems silly to change one and not the other.

A purely stylistic gripe is that you have get_create_function_cmd taking
a PGconn parameter that now has nothing to do with its behavior.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_retainxlog for inclusion in 9.3?
Next
From: Tom Lane
Date:
Subject: Re: PL/perl should fail on configure, not make