Re: pgsql: Move I/O before the index_update_stats() buffer lock region. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Move I/O before the index_update_stats() buffer lock region.
Date
Msg-id 2317336.1730601176@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Move I/O before the index_update_stats() buffer lock region.  (Noah Misch <noah@leadboat.com>)
Responses Re: pgsql: Move I/O before the index_update_stats() buffer lock region.
List pgsql-committers
Noah Misch <noah@leadboat.com> writes:
> Move I/O before the index_update_stats() buffer lock region.

In branches before 17, this commit is causing some compilers
to complain:

index.c: In function 'index_update_stats':
index.c:2913:24: warning: 'relpages' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (rd_rel->relpages != (int32) relpages)
       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~

I'm seeing that with RHEL8's gcc 8.5.0, and trawling the buildfarm
shows at least 40 animals similarly unhappy.  (I noticed this because
mamba, which is using -Werror, is actually failing.)

            regards, tom lane



pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Revert "For inplace update, send nontransactional invalidations.
Next
From: Noah Misch
Date:
Subject: pgsql: Suppress new "may be used uninitialized" warning.