Re: Cleanup isolation specs from unused steps - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Cleanup isolation specs from unused steps
Date
Msg-id 23152.1566226962@sss.pgh.pa.us
Whole thread Raw
In response to Cleanup isolation specs from unused steps  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Cleanup isolation specs from unused steps  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> I have been looking at the isolation tests, and we have in some specs
> steps which are defined but not used in any permutations.

Hmm, might any of those represent actual bugs?  Or are they just
leftovers from test development?

> In order to
> detect them, I have been using the attached trick to track which
> permutations are used.  This allows to find immediately any
> over-engineered spec by generating diffs about steps defined by not
> used in any permutations.  On HEAD, we have six specs entering in this
> category.

Seems like a good idea; I'm surprised we've got so many cases.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Daniel Westermann (DWE)"
Date:
Subject: Wrong sentence in the README?
Next
From: Arne Roland
Date:
Subject: Re: Partial join