Re: [PATCHES] Interval aggregate regression failure - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Interval aggregate regression failure
Date
Msg-id 23114.1157053568@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Interval aggregate regression failure  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [PATCHES] Interval aggregate regression failure  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Well, the patch only multiplies by 30, so the interval would have to
> span +5 million years to overflow.  I don't see any reason to add
> rounding until we get an actual query that needs it

Have you tried your patch against the various cases that have been
discussed in the past?  In particular there were several distinct
examples of this behavior posted at the beginning of the thread, and
I'd not assume that a fix for one handles them all.

BTW, while trolling for examples I came across this:
http://archives.postgresql.org/pgsql-bugs/2005-10/msg00307.php
pointing out some issues that still haven't been addressed.

            regards, tom lane

pgsql-hackers by date:

Previous
From: "Victor B. Wagner"
Date:
Subject: Re: [PATCHES] Backend SSL configuration enhancement
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Interval aggregate regression failure